Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: funman output settings #5226

Merged
merged 19 commits into from
Oct 25, 2024
Merged

feat: funman output settings #5226

merged 19 commits into from
Oct 25, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Oct 21, 2024 •
edited
Loading

  • All state and parameter charts are shown by default
  • Deleted tera-funman-output and moved its contents into the main funman drilldown; this made it easier to apply output settings
  • In the output settings you can check or uncheck the charts you want to view, also the checkboxes for only showing the latest boxes and showing the model checks were moved there
  • Not sure what we exactly want in the individual chart settings here, (do we want annotations?), regardless that should be done in another pass
  • Updated output settings item to have a cog icon button rather than the "Open settings" button
  • Placed the raw funman result in the notebook tab as requested by @liunelson
Screen.Recording.2024-10-22.at.3.22.04.PM.mov

@shawnyama shawnyama linked an issue Oct 22, 2024 that may be closed by this pull request
[FEAT]: output settings in funman #5103
Closed
@shawnyama shawnyama marked this pull request as ready for review October 22, 2024 19:31
@shawnyama shawnyama requested a review from mwdchang October 24, 2024 14:27
@shawnyama shawnyama requested review from jryu01 and Tom-Szendrey and removed request for YohannParis, Tom-Szendrey and blanchco October 24, 2024 14:27
mwdchang
mwdchang approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test, changes look okay

@shawnyama shawnyama merged commit 869ae88 into main Oct 25, 2024
4 checks passed
@shawnyama shawnyama deleted the funman-output-settings branch October 25, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryu01 jryu01 jryu01 approved these changes

@mwdchang mwdchang mwdchang approved these changes

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

Assignees

@jryu01 jryu01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: output settings in funman
3 participants
@shawnyama @mwdchang @jryu01